sts-sponsors team mailing list archive

[Alberto Donato <mp+439150@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/src/maasserver/utils/tests/test_dns.py b/src/maasserver/utils/tests/test_dns.py
> index e6be8ab..863b8d9 100644
> --- a/src/maasserver/utils/tests/test_dns.py
> +++ b/src/maasserver/utils/tests/test_dns.py
> @@ -244,3 +245,13 @@ class TestIpBasedHostnameGenerator(MAASTestCase):
>              get_ip_based_hostname("2001:67c:1562::15"),
>              Equals("2001-67c-1562--15"),
>          )
> +
> +
> +class TestIfaceBasedHostnameGenerator(MAASTestCase):
> +    def test_interface_name_changed(self):
> +        self.expectThat(
> +            get_iface_name_based_hostname("eth_0"), Equals("eth-0")
> +        )
> +
> +    def test_interface_name_unchanged(self):
> +        self.expectThat(get_iface_name_based_hostname("eth0"), Equals("eth0"))

please just use self.assertEqual() for comparison, rather than expectThat for new tests



-- 
https://code.launchpad.net/~tiago.pasqualini/maas/+git/maas/+merge/439150
Your team MAAS Committers is subscribed to branch maas:master.