← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~alexsander-souza/maas-ci/+git/system-tests:add_maas_gitrev_to_report into ~maas-committers/maas-ci/+git/system-tests:master

 

Review: Needs Information



Diff comments:

> diff --git a/systemtests/fixtures.py b/systemtests/fixtures.py
> index ce4c5cd..0cf6a82 100644
> --- a/systemtests/fixtures.py
> +++ b/systemtests/fixtures.py
> @@ -543,6 +540,8 @@ def maas_region(
>          setup_o11y(config["o11y"], maas_container, installed_from_snap)
>      yield region
>  
> +    setattr(request.session, "maas_version", version)

why setattr()?

request.session.maas_version = version

> +
>  
>  @pytest.fixture(scope="session")
>  def unauthenticated_maas_api_client(


-- 
https://code.launchpad.net/~alexsander-souza/maas-ci/+git/system-tests/+merge/440799
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master.



References