sts-sponsors team mailing list archive

[Adam Collard <mp+440799@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1 with nitpick

Diff comments:

> diff --git a/systemtests/conftest.py b/systemtests/conftest.py
> index 58fc4aa..b198c97 100644
> --- a/systemtests/conftest.py
> +++ b/systemtests/conftest.py
> @@ -5,6 +5,7 @@ from logging import getLogger
>  from typing import TYPE_CHECKING, Any, Iterator
>  
>  import pytest
> +from _pytest.terminal import TerminalReporter

move this import to the `if TYPE_CHECKING` block

>  
>  # Important that this comes before importing the modules so that
>  # pytest can rewrite them early.


-- 
https://code.launchpad.net/~alexsander-souza/maas-ci/+git/system-tests/+merge/440799
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master.