← Back to team overview

sts-sponsors team mailing list archive

[Merge] ~ack/maas-site-manager:site-model-fields-types-changes into maas-site-manager:main

 

Alberto Donato has proposed merging ~ack/maas-site-manager:site-model-fields-types-changes into maas-site-manager:main.

Commit message:
change latitude/longitude to strings


Requested reviews:
  MAAS Committers (maas-committers)

For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440956
-- 
Your team MAAS Committers is requested to review the proposed merge of ~ack/maas-site-manager:site-model-fields-types-changes into maas-site-manager:main.
diff --git a/backend/msm/db/_tables.py b/backend/msm/db/_tables.py
index 04513b5..e6806ff 100644
--- a/backend/msm/db/_tables.py
+++ b/backend/msm/db/_tables.py
@@ -23,11 +23,10 @@ Site = Table(
     Column("city", String(250)),
     # ISO 3166 Alpha2
     Column("country", String(2)),
-    # Decimal(8/6)/(9/6) = 16cm precision
-    Column("latitude", Numeric(precision=8, scale=6)),
-    Column("longitude", Numeric(precision=9, scale=6)),
+    Column("latitude", String(20)),
+    Column("longitude", String(20)),
     Column("name", String(250), unique=True),
-    Column("note", Text),
+    Column("note", Text()),
     Column("region", String(250)),
     Column("street", String(250)),
     # Timezones need be up to x.25 accuracy

Follow ups