sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~ack/maas-site-manager:test-cleanups into maas-site-manager:main

To: mp+440972@xxxxxxxxxxxxxxxxxx
From: Thorsten Merten <mp+440972@xxxxxxxxxxxxxxxxxx>
Date: Fri, 14 Apr 2023 07:07:57 -0000
In-reply-to: <168139771558.20442.15589350234093693514.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+440972@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

+1

While reading the update I noticed that we're not really validating and checking validation (especially now that we're using strings for lat/long we could add some validation to the schema). But that's for a different MP.
-- 
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440972
Your team MAAS Committers is subscribed to branch ~ack/maas-site-manager:test-cleanups.

References

[Merge] ~ack/maas-site-manager:test-cleanups into maas-site-manager:main
From: Alberto Donato, 2023-04-13