← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into maas-site-manager:main

 


Diff comments:

> diff --git a/docker-compose.yaml b/docker-compose.yaml
> index b1dbec9..38e90ad 100644
> --- a/docker-compose.yaml
> +++ b/docker-compose.yaml
> @@ -30,6 +30,11 @@ services:
>        - "8000:8000"
>      links:
>        - "postgres:db"
> +    healthcheck:
> +      test: python3 -c "import urllib.request; repr(urllib.request.urlopen(urllib.request.Request('http://localhost:8000')).status)"

shouldn't this command fail if status != 200?

I think you could just `curl -s http://localhost:8000 | false` (to ensure it exits 1 on failure)

> +      interval: 30s
> +      timeout: 30s
> +      retries: 5
>  
>  volumes:
>    postgres-data:


-- 
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is requested to review the proposed merge of ~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into maas-site-manager:main.



References