sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~maas-committers/maas-ci/+git/system-tests:improve-ansible-performance into ~maas-committers/maas-ci/+git/system-tests:master

To: mp+440179@xxxxxxxxxxxxxxxxxx
From: Adam Collard <mp+440179@xxxxxxxxxxxxxxxxxx>
Date: Mon, 17 Apr 2023 13:56:11 -0000
In-reply-to: <168028699169.26171.12990171941190138754.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+440179@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx


Diff comments:

> diff --git a/systemtests/ansible.py b/systemtests/ansible.py
> index 7c671c8..10aedba 100644
> --- a/systemtests/ansible.py
> +++ b/systemtests/ansible.py
> @@ -21,6 +23,9 @@ if TYPE_CHECKING:
>  NAME = "systemtests.ansible"
>  LOG = getLogger(NAME)
>  
> +# match a string "[test_text]" without including the brackets
> +MATCH_HEADERS = r"(?<=\[)[a-zA-Z]+(?=\])"

redundant

> +
>  
>  class MissingRoleOnHost(Exception):
>      """Raised when a host is missing a role they were expected to have."""


-- 
https://code.launchpad.net/~maas-committers/maas-ci/+git/system-tests/+merge/440179
Your team MAAS Committers is requested to review the proposed merge of ~maas-committers/maas-ci/+git/system-tests:improve-ansible-performance into ~maas-committers/maas-ci/+git/system-tests:master.