sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~nickdv99/maas-site-manager:frontend-qa-fixes-MAASENG-1543 into maas-site-manager:main

To: mp+441354@xxxxxxxxxxxxxxxxxx
From: Peter Makowski <mp+441354@xxxxxxxxxxxxxxxxxx>
Date: Wed, 19 Apr 2023 07:26:33 -0000
In-reply-to: <168183421797.10430.1350860656936746061.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+441354@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

This is looking great! Just one thing:
- Tooltips should be activated via a button allowing keyboard access. You will need to wrap each element that's meant to trigger a tooltip with a plain button. Refer to maas-ui where we do similar thing.
-- 
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/441354
Your team MAAS Committers is requested to review the proposed merge of ~nickdv99/maas-site-manager:frontend-qa-fixes-MAASENG-1543 into maas-site-manager:main.

References

[Merge] ~nickdv99/maas-site-manager:frontend-qa-fixes-MAASENG-1543 into maas-site-manager:main
From: Nick De Villiers, 2023-04-18