sts-sponsors team mailing list archive

[Peter Makowski <mp+441449@xxxxxxxxxxxxxxxxxx>]

E2E test sounds like a good idea, I might look into this once all recent changes get merged to make this easier.

Diff comments:

> diff --git a/frontend/src/routes/routes.tsx b/frontend/src/routes/routes.tsx
> index 8b6e071..466ac30 100644
> --- a/frontend/src/routes/routes.tsx
> +++ b/frontend/src/routes/routes.tsx
> @@ -34,19 +35,29 @@ export const routes = createRoutesFromElements(
>      <Route
>        element={
>          <RequireLogin>
> -          <Requests />
> +          <Settings />
>          </RequireLogin>
>        }
> -      path="requests"
> -    />
> -    <Route
> -      element={
> -        <RequireLogin>
> -          <Tokens />
> -        </RequireLogin>
> -      }
> -      path="tokens"
> -    />
> +      path="settings"
> +    >
> +      <Route element={<RequireLogin />} index loader={() => redirect("tokens")} />
> +      <Route
> +        element={
> +          <RequireLogin>
> +            <Tokens />
> +          </RequireLogin>
> +        }
> +        path="tokens"
> +      />
> +      <Route
> +        element={
> +          <RequireLogin>
> +            <Requests />
> +          </RequireLogin>
> +        }
> +        path="requests"
> +      />
> +    </Route>

I like the idea, with the current number of routes it doesn't really seem necessary, so I'd leave that for the future work.

>      <Route path="users" />
>    </Route>,
>  );


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441449
Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:settings-subnavigation-MAASENG-1508.