← Back to team overview

sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into maas-site-manager:main

To: mp+441106@xxxxxxxxxxxxxxxxxx
From: Alberto Donato <mp+441106@xxxxxxxxxxxxxxxxxx>
Date: Thu, 20 Apr 2023 07:03:37 -0000
In-reply-to: <168148597644.11457.15627869596705338175.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+441106@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

+1

please get rid of the repr() and the Request() (the url can be passed directly to urlopen())
-- 
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/441106
Your team MAAS Committers is subscribed to branch ~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck.

References

[Merge] ~thorsten-merten/maas-site-manager:make-tox-rebuild-reqs-add-healthcheck into maas-site-manager:main
From: Thorsten Merten, 2023-04-14