sts-sponsors team mailing list archive

[Nick De Villiers <mp+441890@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information

One question/comment before approving, see diff comments

Diff comments:

> diff --git a/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx b/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx
> index a4c2b15..a6a4354 100644
> --- a/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx
> +++ b/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx
> @@ -46,15 +45,20 @@ const TokensTable = ({
>        {
>          id: "select",
>          header: ({ table }) => <SelectAllCheckbox table={table} />,
> -        cell: ({ row }) => (
> -          <div>
> -            <Input
> -              checked={row.getIsSelected()}
> -              disabled={!row.getCanSelect()}
> -              onChange={row.getToggleSelectedHandler()}
> +        cell: ({ row, getValue }) => (
> +          <label className="p-checkbox--inline">
> +            <input

Does this need to be a standard HTML input or can it be a vanilla Input?

> +              aria-label={`select ${getValue()}`}
> +              className="p-checkbox__input"
>                type="checkbox"
> +              {...{
> +                checked: row.getIsSelected(),
> +                disabled: !row.getCanSelect(),
> +                onChange: row.getToggleSelectedHandler(),
> +              }}
>              />
> -          </div>
> +            <span className="p-checkbox__label" />
> +          </label>
>          ),
>        },
>        {


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:add-a11y-tests.