sts-sponsors team mailing list archive

[Peter Makowski <mp+442000@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/frontend/src/components/base/TablePagination/TablePagination.tsx b/frontend/src/components/base/TablePagination/TablePagination.tsx
> index c716638..070f187 100644
> --- a/frontend/src/components/base/TablePagination/TablePagination.tsx
> +++ b/frontend/src/components/base/TablePagination/TablePagination.tsx
> @@ -34,10 +34,9 @@ const TablePagination = ({
>          setError(`${valueAsNumber} is not a valid page`);
>        } else {
>          setError("");
> -        setCurrentPage(valueAsNumber - 1);
> +        setCurrentPage(valueAsNumber);

Missed this single place when updating pagination to start at index 1.

>        }
>      } else {
> -      setPageNumber(undefined);
>        setError("Enter a page number.");
>      }
>    };


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442000
Your team MAAS Committers is requested to review the proposed merge of ~petermakowski/maas-site-manager:pagination-e2e-test into maas-site-manager:main.