sts-sponsors team mailing list archive

[Anton Troyanov <mp+442131@xxxxxxxxxxxxxxxxxx>]

Anton Troyanov has proposed merging ~troyanov/maas:go-lint-all into maas:master.

Commit message:
ci: improve golangci-lint settings

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442131
-- 
Your team MAAS Committers is subscribed to branch maas:master.

diff --git a/.golangci.yaml b/.golangci.yaml
index 6855546..534bef9 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -90,12 +90,22 @@ linters:
     - nonamedreturns
     - revive
     - staticcheck
+    - stylecheck
     - tagliatelle
     - unused
     - whitespace
     - wsl
 
 linters-settings:
+  revive:
+    rules:
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#package-comments
+      - name: package-comments
+        disabled: true
+  staticcheck:
+    checks: ["all"]
+  stylecheck:
+    checks: ["all"]
 
 
 issues:
@@ -148,14 +158,8 @@ issues:
   # Default: false.
   new: false
 
-  # Show only new issues created after git revision `REV`.
-  new-from-rev: HEAD
-
-  # Show only new issues created in git patch with set file path.
-  # new-from-patch: path/to/patch/file
-
   # Fix found issues (if it's supported by the linter).
-  fix: true
+  fix: false
 
 
 severity: