sts-sponsors team mailing list archive

[Anton Troyanov <mp+442177@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTMWC

Diff comments:

> diff --git a/src/maasserver/models/domain.py b/src/maasserver/models/domain.py
> index a793e01..5dccc9f 100644
> --- a/src/maasserver/models/domain.py
> +++ b/src/maasserver/models/domain.py
> @@ -172,12 +178,11 @@ class Domain(CleanSave, TimestampedModel):
>      :ivar objects: An instance of the class :class:`DomainManager`.
>      """
>  
> -    class Meta:

Why this is not needed anymore?

> -        verbose_name = "Domain"
> -        verbose_name_plural = "Domains"
> -
>      objects = DomainManager()
>  
> +    # explicitly define the AutoField since default is BigAutoField which
> +    # doesn't allow 0 as a value (used for the default domain)
> +    id = AutoField(primary_key=True)
>      name = DomainNameField(
>          max_length=256,
>          editable=True,


-- 
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
Your team MAAS Committers is subscribed to branch maas:master.