← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~ack/maas:big-auto-field-default into maas:master

 


Diff comments:

> diff --git a/src/maasserver/models/domain.py b/src/maasserver/models/domain.py
> index a793e01..5dccc9f 100644
> --- a/src/maasserver/models/domain.py
> +++ b/src/maasserver/models/domain.py
> @@ -172,12 +178,11 @@ class Domain(CleanSave, TimestampedModel):
>      :ivar objects: An instance of the class :class:`DomainManager`.
>      """
>  
> -    class Meta:

This is mostly relevant to the builtin admin interface (which we don't use) and some error messages, but default values are the same, just not capitalized. There's no real reason to override them.
To be clear, this change is an unrelated cleanup.

> -        verbose_name = "Domain"
> -        verbose_name_plural = "Domains"
> -
>      objects = DomainManager()
>  
> +    # explicitly define the AutoField since default is BigAutoField which
> +    # doesn't allow 0 as a value (used for the default domain)
> +    id = AutoField(primary_key=True)
>      name = DomainNameField(
>          max_length=256,
>          editable=True,


-- 
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
Your team MAAS Committers is subscribed to branch maas:master.



References