sts-sponsors team mailing list archive

[Nick De Villiers <mp+442192@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> index f3ee36a..a6b850d 100644
> --- a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> +++ b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> @@ -1,4 +1,21 @@
>  .tokens-table {
> +
> +  thead th {
> +    position: sticky;
> +    top: -0.75rem;
> +    background-color: white;
> +    z-index: 1;
> +    padding-top: $spv--large;
> +
> +    @media only screen and (min-width: $breakpoint-small){
> +      top: calc(34.6875rem - 0.75rem);
> +    }
> +
> +    @media only screen and (min-width: $breakpoint-large) {
> +      top: calc(23.4375rem - 0.75rem);

Creating variables would probably be the better bet here - each of these values is the maximum height of the content of the header for each breakpoint, and this has to be static - otherwise the top value for the table header won't be correct

> +    }
> +  }
> +
>    thead th:first-child {
>      width: 3rem;
>    }


-- 
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192
Your team MAAS Committers is requested to review the proposed merge of ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main.