← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

 


Diff comments:

> diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss
> index 0588138..bdcb88c 100644
> --- a/frontend/src/_settings.scss
> +++ b/frontend/src/_settings.scss
> @@ -2,11 +2,9 @@
>  
>  // Vanilla settings:
>  $grid-max-width: math.div(1920, 16) * 1rem;
> -
>  $breakpoint-xx-large: 1920px;
>  $side-navigation-z-index: 103;
> +/* stylelint-disable-next-line scss/dollar-variable-pattern */

Wait really? I thought this variable was defined by us locally in MAAS UI and here

>  $application-layout--breakpoint-side-nav-expanded: $breakpoint-xx-large;
> -
>  $increase-font-size-on-larger-screens: false;
> -
>  $assets-path: "/assets/fonts/";


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220
Your team MAAS Committers is requested to review the proposed merge of ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main.



References