← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

 


Diff comments:

> diff --git a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> index 2dd28ec..1793d8e 100644
> --- a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> +++ b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> @@ -3,6 +3,22 @@
>    th {
>      vertical-align: middle;
>    }
> +  
> +  thead th {
> +    position: sticky;
> +    top: -0.75rem;
> +    background-color: white;
> +    z-index: 1;
> +    padding-top: $spv--large;
> +
> +    @media only screen and (min-width: $breakpoint-small){
> +      top: calc($header-height-medium - 0.75rem);

You seem to have missed $spv--medium in a few places.

> +    }
> +
> +    @media only screen and (min-width: $breakpoint-large) {
> +      top: calc($header-height-large - 0.75rem);
> +    }
> +  }
>  
>    thead th:first-child {
>      width: 3rem;


-- 
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192
Your team MAAS Committers is requested to review the proposed merge of ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main.



References