sts-sponsors team mailing list archive

[Alberto Donato <mp+442130@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1

small nit inline

Diff comments:

> diff --git a/maas_release_tools/scripts/release_status.py b/maas_release_tools/scripts/release_status.py
> index 67ecb57..7beeac4 100644
> --- a/maas_release_tools/scripts/release_status.py
> +++ b/maas_release_tools/scripts/release_status.py
> @@ -1396,11 +1397,16 @@ def main():
>          credentials_file=args.launchpad_credentials,
>          dry_run=args.dry_run,
>      )
> -    jenkins = JenkinsActions(
> -        dry_run=args.jenkins_skip,
> -        jenkins_config=args.jenkins_config,
> -        server_section=args.jenkins_section,
> -    )
> +    try:
> +        jenkins = JenkinsActions(
> +            dry_run=args.jenkins_skip,
> +            jenkins_config=args.jenkins_config,
> +            server_section=args.jenkins_section,
> +        )
> +    except JenkinsConfigMissing as e:
> +        print("Jenkins API not configured:")

we should print this to stderr too

> +        print(e, file=sys.stderr)
> +        return 1
>      release_version = ReleaseVersion(args.version)
>      preparer = ReleasePreparer(
>          release_version,


-- 
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/442130
Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main.