sts-sponsors team mailing list archive

[Jack Lloyd-Walters <mp+442427@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Lgtm

Diff comments:

> diff --git a/backend/msm/db/queries.py b/backend/msm/db/queries.py
> index 9248559..3e51fbb 100644
> --- a/backend/msm/db/queries.py
> +++ b/backend/msm/db/queries.py
> @@ -122,8 +122,7 @@ async def get_filtered_sites(
>          timezone=timezone,
>          url=url,
>      )
> -    if accepted is not None:
> -        filters.append(Site.c.accepted == accepted)
> +    filters.append(Site.c.accepted == True)  # noqa
>      count = (

’filters.append(bool(Site.c.appended))’, or do we not expect this to be sanitised?

>          await session.execute(
>              select(func.count())


-- 
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442427
Your team MAAS Committers is subscribed to branch ~ack/maas-site-manager:pending-sites-endpoint.