sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~jonesogolo/maas-site-manager:1602-display-token-delete-failure-msg into maas-site-manager:main

To: mp+442449@xxxxxxxxxxxxxxxxxx
From: Peter Makowski <mp+442449@xxxxxxxxxxxxxxxxxx>
Date: Fri, 05 May 2023 11:49:41 -0000
In-reply-to: <168328685590.28862.18283089693762237694.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+442449@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

I noticed you placed tests in TokensListDelete.test.tsx but there is no component file named TokensListDelete.tsx. Let's follow our convention and place tests in the file related to the component it's testing (TokensList.tsx, TokensList.test.tsx).
-- 
https://code.launchpad.net/~jonesogolo/maas-site-manager/+git/maas-site-manager/+merge/442449
Your team MAAS Committers is requested to review the proposed merge of ~jonesogolo/maas-site-manager:1602-display-token-delete-failure-msg into maas-site-manager:main.