← Back to team overview

sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~ack/maas-site-manager:api-tests-grouping into maas-site-manager:main

To: mp+442485@xxxxxxxxxxxxxxxxxx
From: Thorsten Merten <mp+442485@xxxxxxxxxxxxxxxxxx>
Date: Tue, 09 May 2023 07:19:54 -0000
In-reply-to: <168354917686.28859.10350412789743450276.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+442485@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

nice refactor.
Small note: While scrolling through I noticed that Sites are defined quite often in the same way. Maybe we can add a place to import some fixture definitions from.
-- 
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442485
Your team MAAS Committers is subscribed to branch ~ack/maas-site-manager:api-tests-grouping.