sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

To: mp+442538@xxxxxxxxxxxxxxxxxx
From: Christian Grabowski <mp+442538@xxxxxxxxxxxxxxxxxx>
Date: Tue, 09 May 2023 14:25:39 -0000
In-reply-to: <168364156894.1440599.10550617566925160759.codereview@juju-98d295-prod-launchpad-3>
Reply-to: mp+442538@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

> I see that your PR to go-pcap was merged. Nice!
> 
> Should we makes changes to our code in order to benefit from VLAN tags parsing
> in go-pcap?

Thanks! So no changes are needed in our code, the existing parser will just see the ethernet type and should already parse the VLAN tag.
-- 
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/442538
Your team MAAS Committers is subscribed to branch maas:master.

References

Re: [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master
From: Anton Troyanov, 2023-05-09