sts-sponsors team mailing list archive
-
sts-sponsors team
-
Mailing list archive
-
Message #08377
[Merge] ~jonesogolo/maas-site-manager:fix-pagination-select-label into maas-site-manager:main
Jones Ogolo has proposed merging ~jonesogolo/maas-site-manager:fix-pagination-select-label into maas-site-manager:main.
Commit message:
Rename select label for pagination bar
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~jonesogolo/maas-site-manager/+git/maas-site-manager/+merge/442835
Rename select label for pagination bar
--
Your team MAAS Committers is requested to review the proposed merge of ~jonesogolo/maas-site-manager:fix-pagination-select-label into maas-site-manager:main.
diff --git a/frontend/src/components/base/PaginationBar/PaginationBar.test.tsx b/frontend/src/components/base/PaginationBar/PaginationBar.test.tsx
index 57d4e74..841b276 100644
--- a/frontend/src/components/base/PaginationBar/PaginationBar.test.tsx
+++ b/frontend/src/components/base/PaginationBar/PaginationBar.test.tsx
@@ -16,7 +16,7 @@ it("should render the PaginationBar component correctly", () => {
totalItems={50}
/>,
);
- expect(screen.getByRole("combobox", { name: /tokens per page/i })).toBeInTheDocument();
+ expect(screen.getByRole("combobox", { name: /items per page/i })).toBeInTheDocument();
expect(screen.getByRole("navigation", { name: /pagination/i })).toBeInTheDocument();
expect(screen.getByText(/showing/i)).toBeInTheDocument();
});
diff --git a/frontend/src/components/base/PaginationBar/PaginationBar.tsx b/frontend/src/components/base/PaginationBar/PaginationBar.tsx
index 69d8bb4..6847be8 100644
--- a/frontend/src/components/base/PaginationBar/PaginationBar.tsx
+++ b/frontend/src/components/base/PaginationBar/PaginationBar.tsx
@@ -66,8 +66,8 @@ const PaginationBar = ({
/>
<Select
- aria-label="Tokens per page"
- name="Tokens per page"
+ aria-label="Items per page"
+ name="Items per page"
onChange={handleSizeChange}
options={pageOptions}
value={itemsPerPage}