← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~ack/maas:workers-stop-no-change-iter into maas:master

 

This should prevent issues like

2023-05-25 15:58:29 twisted.internet.defer: [critical] Unhandled error in Deferred:
2023-05-25 15:58:29 twisted.internet.defer: [critical] 
	Traceback (most recent call last):
	  File "/snap/maas/28082/usr/lib/python3/dist-packages/twisted/internet/base.py", line 492, in fireEvent
	    result = callable(*args, **kwargs)
	  File "/snap/maas/28082/usr/lib/python3/dist-packages/twisted/application/service.py", line 284, in stopService
	    l.append(defer.maybeDeferred(service.stopService))
	  File "/snap/maas/28082/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 190, in maybeDeferred
	    result = f(*args, **kwargs)
	  File "/snap/maas/28082/usr/lib/python3/dist-packages/twisted/application/service.py", line 284, in stopService
	    l.append(defer.maybeDeferred(service.stopService))
	--- <exception caught here> ---
	  File "/snap/maas/28082/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 190, in maybeDeferred
	    result = f(*args, **kwargs)
	  File "/snap/maas/28082/lib/python3.10/site-packages/maasserver/workers.py", line 77, in stopService
	    for pid, worker in self.workers.items():
	builtins.RuntimeError: dictionary changed size during iteration

-- 
https://code.launchpad.net/~ack/maas/+git/maas/+merge/443645
Your team MAAS Committers is subscribed to branch maas:master.