sts-sponsors team mailing list archive

[Adam Collard <mp+443651@xxxxxxxxxxxxxxxxxx>]

Adam Collard has proposed merging ~adam-collard/maas:flaky-profile-name into maas:master.

Commit message:
fix: flaky maas_user profile name

Keep trying usernames until we find one that doesn't start with a -


Requested reviews:
  MAAS Maintainers (maas-maintainers)
Related bugs:
  Bug #2020865 in MAAS: "flaky test: src/tests/maasperf/cli/test_machines.py::test_perf_list_machines_CLI"
  https://bugs.launchpad.net/maas/+bug/2020865

For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/443651
-- 
Your team MAAS Committers is subscribed to branch maas:master.

diff --git a/src/tests/maasperf/cli/conftest.py b/src/tests/maasperf/cli/conftest.py
index 79aeba8..1f24962 100644
--- a/src/tests/maasperf/cli/conftest.py
+++ b/src/tests/maasperf/cli/conftest.py
@@ -10,7 +10,12 @@ from pytest import fixture
 
 @fixture()
 def maas_user(factory):
-    return factory.make_User()
+    user = factory.make_User()
+    # Ensure that the username is valid as a profile name, i.e doesn't
+    # start with a special char. See LP:2020865
+    while not user[0].isalpha():
+        user = factory.make_User()
+    return user
 
 
 @fixture()