sts-sponsors team mailing list archive

Thread
Date

Re: [Merge] ~alexsander-souza/maas:disable_debug_in_perf_tests into maas:master

To: mp+443444@xxxxxxxxxxxxxxxxxx
From: Adam Collard <mp+443444@xxxxxxxxxxxxxxxxxx>
Date: Fri, 26 May 2023 13:37:05 -0000
In-reply-to: <168488356858.25517.3948026101276480570.launchpad@juju-4112d9-prod-launchpad-manual-servers-36.openstack.prodstack5.lan>
Reply-to: mp+443444@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

thanks! nit pick below

Diff comments:

> diff --git a/tox.ini b/tox.ini
> index 59e2209..6cbd791 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -42,6 +42,7 @@ lint =
>      src/provisioningserver \
>      src/provisioningserver/refresh/50-maas-01-commissioning \
>      src/tests/ \
> +    src/maastesting/ \

sort this (between maasserver and metadataserver)

>      utilities/bin2python.py \
>      utilities/check-imports \
>      utilities/check-oapi \


-- 
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/443444
Your team MAAS Committers is subscribed to branch maas:master.