sts-sponsors team mailing list archive

[Alberto Donato <mp+443670@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1 with a minor change inline

Diff comments:

> diff --git a/maaskpi/dailystats.py b/maaskpi/dailystats.py
> index 56f5526..0576768 100644
> --- a/maaskpi/dailystats.py
> +++ b/maaskpi/dailystats.py
> @@ -178,6 +178,19 @@ class DeploymentStats(StatsMixin):
>      # number of deployments this stat is aggregating counts for
>      deployment_count: int = 1
>  
> +    tags_total_count: int = 0
> +    tags_automatic_tag_count: int = 0
> +    tags_with_kernel_opts_count: int = 0
> +
> +    dhcp_snippets_node_count: int = 0
> +    dhcp_snippets_subnet_count: int = 0
> +    dhcp_snippets_global_count: int = 0
> +
> +    vault_enabled: bool = False
> +
> +    tls_configuration_enabled: bool = False

vault_enabled and tls_configuration_enabled should be int (and default to 0) too, since get() always returns an int (when stats are aggregated, these are summed up).

> +    tls_configuration_cert_validity_days: int = 0
> +
>  
>  class DailyStatsSeries(SeriesHelper):
>      class Meta:


-- 
https://code.launchpad.net/~troyanov/maas-kpi/+git/maas-kpi/+merge/443670
Your team MAAS Committers is subscribed to branch maas-kpi:master.