← Back to team overview

sts-sponsors team mailing list archive

[Merge] ~alexsander-souza/maas:fix_flaky_test_GET_includes_numa_nodes into maas:master

 

Alexsander de Souza has proposed merging ~alexsander-souza/maas:fix_flaky_test_GET_includes_numa_nodes into maas:master.

Commit message:
fix flaky test_GET_includes_numa_nodes()
    
numanode_set is not ordered

Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/443748
-- 
Your team MAAS Committers is subscribed to branch maas:master.
diff --git a/src/maasserver/api/tests/test_machines.py b/src/maasserver/api/tests/test_machines.py
index 0104f68..9e88c40 100644
--- a/src/maasserver/api/tests/test_machines.py
+++ b/src/maasserver/api/tests/test_machines.py
@@ -454,7 +454,7 @@ class TestMachinesAPI(APITestCase.ForUser):
         factory.make_NUMANode(node=machine, memory=2048 * 1024, cores=[0, 1])
         factory.make_NUMANode(node=machine, memory=4096 * 1024, cores=[2, 3])
         [parsed_result] = self.get_json()
-        self.assertEqual(
+        self.assertCountEqual(
             parsed_result["numanode_set"],
             [
                 {"index": 0, "memory": 0, "cores": [], "hugepages_set": []},

Follow ups