← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~troyanov/maas:check-dmidecode into maas:master

 

Review: Approve

+1, with some nits:

- add this check to Wedge protocol (same file), as it also relies on dmidecode
- the reason we don't declare dmidecode as a dependency of this script is that there isn't a package for all platforms MAAS deploys (https://packages.ubuntu.com/jammy/dmidecode). Given that, should we be relying on it? 
-- 
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/444076
Your team MAAS Committers is subscribed to branch maas:master.



References