team4alfanous team mailing list archive

[noreply@xxxxxxxxxxxxx]

Merge authors:
  zsmahi <zakaria08esi@xxxxxxxxx>
------------------------------------------------------------
revno: 326 [merge]
committer: Zakaria SMAHI <zakaria08esi@xxxxxxxxx>
timestamp: Fri 2012-08-31 06:25:42 -0700
message:
  Merge pull request #66 from zsmahi/master
  
  New changes on Alfanous toolbar
modified:
  interfaces/toolbars/firefox/CHANGELOG
  interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.js
  interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.xul


--
lp:alfanous
https://code.launchpad.net/~team4alfanous/alfanous/alfanous-git

Your team Alfanous team is subscribed to branch lp:alfanous.
To unsubscribe from this branch go to https://code.launchpad.net/~team4alfanous/alfanous/alfanous-git/+edit-subscription

=== modified file 'interfaces/toolbars/firefox/CHANGELOG'
--- interfaces/toolbars/firefox/CHANGELOG	2012-08-19 03:15:21 +0000
+++ interfaces/toolbars/firefox/CHANGELOG	2012-08-31 11:14:14 +0000
@@ -1,3 +1,8 @@
+2012-08-31  zaki Smahi <zakaria08esi@xxxxxxxxx>
+
+    	* TODO  LIST to next update 0.6
+		* open  links in  new tab instead of getting last browser window
+
 2012-08-19  zaki Smahi <zakaria08esi@xxxxxxxxx>
 
     	* launching the first release 0.5

=== modified file 'interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.js'
--- interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.js	2012-08-08 17:51:29 +0000
+++ interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.js	2012-08-31 11:14:14 +0000
@@ -4,7 +4,12 @@
 	by SMAHI Zakaria
 	zakaria08esi@xxxxxxxxx
 */
-
+/*
+TODO  LIST
+	# open  links in  new tab instead of getting last browser window  ......... done
+	# use one regexp to trim " "
+	# enable search history and autocomplete
+ */
 
  
 	function AlfanousTB_Search(event, type)
@@ -117,10 +122,9 @@
 		
 		/*
 			AlfanousTB_LoadURL
-			This function loads the specified URL in the browser
+			This function loads the specified URL in the browser (new tab)
 		*/
-var win = Components.classes['@mozilla.org/appshell/window-mediator;1'].getService(Components.interfaces.nsIWindowMediator).getMostRecentWindow('navigator:browser');
-win.openUILinkIn(url, 'current');
+		gBrowser.selectedTab = gBrowser.addTab(url);
 	}
 
 	function AlfanousTB_KeyHandler(event)
@@ -159,14 +163,14 @@
 		// Specify how many items we should add to the menu
 		var numItemsToAdd = 10;
 
-		tempItem.setAttribute("label", "الحمد لله رب العالمين");
+		tempItem.setAttribute("label", "allah");
 		for(var i=0; i<numItemsToAdd; i++)
 		{
 			// Create a new menu item to be added
 			var tempItem = document.createElement("menuitem");
 
 			// Set the new menu item's label
-			//tempItem.setAttribute("label", "Dynamic Item Number " + (i+1));
+			tempItem.setAttribute("label", "Dynamic Item Number " + (i+1));
 
 			// Add the item to our menu
 			menu.appendChild(tempItem);

=== modified file 'interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.xul'
--- interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.xul	2012-08-17 15:00:51 +0000
+++ interfaces/toolbars/firefox/chrome/content/alfanoustoolbar.xul	2012-08-31 11:14:14 +0000
@@ -7,6 +7,13 @@
 	zakaria08esi@xxxxxxxxx
 							-->
 
+							
+<!-- 
+	TODO  LIST
+	# use textbox instead of toolbaritem id="AlfanousTB-SearchTerms-TBItem"
+	# enable search history and autocomplete in textbox
+							-->							
+							
 <!-- css sheet used -->
 
 <?xml-stylesheet href="chrome://alfanoustoolbar/skin/alfanoustoolbar.css" type="text/css"?>