testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

On Mon, Oct 18, 2010 at 10:38 AM, Robert Collins
<robertc@xxxxxxxxxxxxxxxxx> wrote:
> Review: Approve
>
> 220     +    def _run_test_method(self, result):
> 221     +        """Run the test method for this test.
> 222     +
> 223     +        :param result: A testtools.TestResult to report activity to.
> 224     +        :return: None.
> 225     +        """
> 226     +        self._get_test_method()()
>
> triggers the smells wrong smell - result isn't used.

It was like that when I got there. Compare with trunk:

    def _run_test_method(self, result):
        """Run the test method for this test.

        :param result: A testtools.TestResult to report activity to.
        :return: None.
        """
        absent_attr = object()
        # Python 2.5+
        method_name = getattr(self, '_testMethodName', absent_attr)
        if method_name is absent_attr:
            # Python 2.4
            method_name = getattr(self, '_TestCase__testMethodName')
        testMethod = getattr(self, method_name)
        testMethod()

I don't know why 'result' is a parameter to _run_test_method,
_run_setup or _run_teardown. Perhaps for greater API flexibility?
Those methods are called by RunTest.

jml
-- 
https://code.launchpad.net/~jml/testtools/run-test-improvements/+merge/38659
Your team testtools developers is subscribed to branch lp:testtools.