testtools-dev team mailing list archive

["Martin \[gz\]" <gzlist@xxxxxxxxxxxxxx>]

Martin [gz] has proposed merging lp:~gz/testtools/fix_test_preserve_signal_handler into lp:testtools.

Requested reviews:
  testtools developers (testtools-dev)


Simply creates and checks the number of signal handlers that will actually be installed rather than always three.
-- 
https://code.launchpad.net/~gz/testtools/fix_test_preserve_signal_handler/+merge/39284
Your team testtools developers is requested to review the proposed merge of lp:~gz/testtools/fix_test_preserve_signal_handler into lp:testtools.

=== modified file 'testtools/tests/test_spinner.py'
--- testtools/tests/test_spinner.py	2010-10-24 08:41:51 +0000
+++ testtools/tests/test_spinner.py	2010-10-25 15:29:44 +0000
@@ -170,7 +170,7 @@
             None, (getattr(signal, name, None) for name in signals))
         for sig in signals:
             self.addCleanup(signal.signal, sig, signal.getsignal(sig))
-        new_hdlrs = [lambda *a: None, lambda *a: None, lambda *a: None]
+        new_hdlrs = list(lambda *a: None for _ in signals)
         for sig, hdlr in zip(signals, new_hdlrs):
             signal.signal(sig, hdlr)
         spinner = self.make_spinner()