testtools-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Sat, Nov 20, 2010 at 7:27 AM, Martin [gz] <gzlist@xxxxxxxxxxxxxx> wrote:
> Martin [gz] has proposed merging lp:~gz/testtools/raises_regressions_675327 into lp:testtools.
>
> Requested reviews:
>  testtools developers (testtools-dev)
> Related bugs:
>  #675327 Raises/MatchesException regressions
>  https://bugs.launchpad.net/bugs/675327
>
>
> Fixes the fallout on Python 2.4 and Python 3 from merging <https://code.launchpad.net/~lifeless/testtools/matchers/+merge/40606>.
>
> The only behaviour change is str(MatchesException(Exception)) now returns "MatchesException(Exception)" rather than "MatchesException(<type 'exceptions.Exception'>)" which I think is nicer and makes life easier as across 2.4->2.5->3 you get three different reprs. Oh, and that exception classes custom repr methods now won't get used, which may be a good or bad thing for clarity, but should be safer at least.

I explicitly didn't do this because class names are not unique, and
thats bad for debuggability.

We can special case exceptions.* types to show just the classname, if
we want, but debuggability has to be waaaay up there in requirements.

Whats unsafe about what I'd done?

-Rob
-- 
https://code.launchpad.net/~gz/testtools/raises_regressions_675327/+merge/41342
Your team testtools developers is requested to review the proposed merge of lp:~gz/testtools/raises_regressions_675327 into lp:testtools.