← Back to team overview

testtools-dev team mailing list archive

[Merge] lp:~jml/testtools/unexpected-success-2 into lp:testtools

 

Jonathan Lange has proposed merging lp:~jml/testtools/unexpected-success-2 into lp:testtools.

Requested reviews:
  testtools developers (testtools-dev)
Related bugs:
  #654474 An unexpectedSuccess is like a failure not a success
  https://bugs.launchpad.net/bugs/654474


This branch finished off the rest of bug 654474.  It changes the contract of TestResult such that wasSuccessful returns False if there has ever been an unexpected success.

In addition, it updates the contract tests to test for the behaviour of wasSuccessful in many more cases, and adds contract tests for Python 2.6 and 2.7 which we run against our fake implementations.

-- 
https://code.launchpad.net/~jml/testtools/unexpected-success-2/+merge/42050
Your team testtools developers is requested to review the proposed merge of lp:~jml/testtools/unexpected-success-2 into lp:testtools.



Follow ups