testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

On Fri, Dec 10, 2010 at 11:51 PM, Martin [gz] <gzlist@xxxxxxxxxxxxxx> wrote:
> `all` is a pretty trivial function, it's just a question of preference
> whether you want to catch NameError at the top of the file and write it
> there, or at some common location and add it to __builtin__, or expose
> from there and always use qualified.

Ideally, it wouldn't be at the top of the file, but in compat instead.
No need to add it to builtin or use qualified, we can either mask the
builtin or give it a different name (e.g. all_true).

But no real preference.

jml

** Changed in: testtools
     Assignee: (unassigned) => Martin [gz] (gz)

** Changed in: testtools
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of testtools
developers, which is subscribed to testtools.
https://bugs.launchpad.net/bugs/688724

Title:
  MultiTestResult.wasSuccessful broken in Python 2.4

Status in testtools:
  Fix Committed

Bug description:
  MultiTestResult.wasSuccessful uses 'all', which is not available in Python 2.4. Thus, it breaks.