testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

This is not a release blocker. It has affected numerous releases before
now and is caused by the fact that Python's "standard"
addExpectedFailure has a different order of arguments to Twisted's
addExpectedFailure.


** Changed in: testtools
   Importance: Critical => Medium

-- 
You received this bug notification because you are a member of testtools
developers, which is subscribed to testtools.
https://bugs.launchpad.net/bugs/611297

Title:
  Cannot run testtools test suite with trial

Status in testtools:
  Triaged

Bug description:
  We should be able to run the testtools test suite with trial, but as of r74 we cannot.

trial testtools
... 
 TestNonAsciiResults
    test_assertion_text_shift_jis ...                                      [OK]
    test_control_characters_in_failure_string ... Traceback (most recent call last):
  File "/home/jml/src/Twisted/trunk/bin/trial", line 21, in <module>
    run()
  File "/home/jml/src/Twisted/trunk/twisted/scripts/trial.py", line 363, in run
    test_result = trialRunner.run(suite)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 857, in run
    return self._runWithoutDecoration(test)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 886, in _runWithoutDecoration
    run()
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 881, in <lambda>
    run = lambda: suite.run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 298, in run
    TestSuite.run(self, result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1390, in run
    test(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1378, in __call__
    return self.run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 174, in run
    super(LoggedSuite, self).run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1390, in run
    test(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1378, in __call__
    return self.run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 147, in run
    test(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1378, in __call__
    return self.run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/runner.py", line 147, in run
    test(result)
  File "/usr/lib/python2.6/unittest.py", line 464, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.6/unittest.py", line 460, in run
    test(result)
  File "/usr/lib/python2.6/unittest.py", line 464, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.6/unittest.py", line 460, in run
    test(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1413, in __call__
    return self.run(result)
  File "/home/jml/src/Twisted/trunk/twisted/trial/unittest.py", line 1423, in run
    reporter._AdaptedReporter(result, self.__class__))
  File "/home/jml/src/testtools/release-0.9.5/testtools/testcase.py", line 380, in run
    return self.__RunTest(self, self.exception_handlers).run(result)
  File "/home/jml/src/testtools/release-0.9.5/testtools/runtest.py", line 67, in run
    return self._run_one(actual_result)
  File "/home/jml/src/testtools/release-0.9.5/testtools/runtest.py", line 81, in _run_one
    return self._run_prepared_result(ExtendedToOriginalDecorator(result))
  File "/home/jml/src/testtools/release-0.9.5/testtools/runtest.py", line 100, in _run_prepared_result
    handler(self.case, self.result, e)
  File "/home/jml/src/testtools/release-0.9.5/testtools/testcase.py", line 352, in _report_expected_failure
    result.addExpectedFailure(self, details=self.getDetails())
  File "/home/jml/src/testtools/release-0.9.5/testtools/testresult/real.py", line 415, in addExpectedFailure
    return addExpectedFailure(test, err)
TypeError: addExpectedFailure() takes exactly 4 arguments (3 given)