testtools-dev team mailing list archive

["Martin \[gz\]" <gzlist@xxxxxxxxxxxxxx>]

** Tags added: python27
** Tags removed: python2.7

-- 
You received this bug notification because you are a member of testtools
developers, which is subscribed to testtools.
https://bugs.launchpad.net/bugs/625583

Title:
  Strange details item reprs on skipped tests in babune

Status in Bazaar Version Control System:
  Confirmed
Status in testtools:
  Fix Released

Bug description:
  Skipped tests appear in the babune output logs on Python 2.7 labelled not as 'ok' but instead 'skipped <repr-of-testtools-details>'.

This is understandable, though ugly, when it's the 'reason' attachment being output:

bzrlib.tests.per_branch.test_branch.TestReferenceLocation.test_sprout_copies_reference_location(RemoteBranchFormat-default) (subunit.RemotedTestCase)
bzrlib.tests.per_branch.test_branch.TestReferenceLocation.test_sprout_copies_reference_location(RemoteBranchFormat-default) ... skipped u'Text attachment: reason\n------------\nBranch cannot hold references.\n------------\n'

But some tests instead have the 'log':

bzrlib.tests.per_branch.test_locking.TestBranchLocking.test_lock_write_with_nonmatching_token(BranchReferenceFormat) (subunit.RemotedTestCase)
bzrlib.tests.per_branch.test_locking.TestBranchLocking.test_lock_write_with_nonmatching_token(BranchReferenceFormat) ... skipped u"Text attachment: log\n------------\n57.587  creating repository in file:///tmp/testbzr-QuHQFd.tmp/bzrlib.tests.per_branch.test_locking.TestBranchLocking.test_lock_write_with_nonmatching_token%28BranchReferenceFormat%29/work/b/.bzr/.\n57.591  opening working tree '/tmp/testbzr-QuHQFd.tmp'\n------------\nText attachment: reason\n------------\nUninitializable branch format\n------------\n"

This is likely down to testtools using the new skip handling in the Python 2.7 unittest, but I'm not sure if the bug needs fixing in bzr, or testtools, or subunit.