← Back to team overview

testtools-dev team mailing list archive

Re: [Merge] lp:~allenap/testtools/lessthan-mismatch-string into lp:testtools

 

 Wed, Apr 13, 2011 at 8:23 PM, Gavin Panella
<gavin.panella@xxxxxxxxxxxxx> wrote:
> Mmm, I'm not sure:
>
>  >>> LessThan(4.0).match(4.1).describe()
>  '4.0 is >= 4.0999999999999996'
>
> I think that a description of the test would be '4.0 is > 4.1', and a
> description of the outcome would be '4.0 is not > 4.1'.

The output that was printed is clearly bong (and thats a bug). It
should say '<'.
'not >' would be wrong, because == is permitted.

Basically the output arguments are inverted - the result of match is a
*mis*match.
So 'it is not true that '4.1' (the thing being matched') is < '4.0'
(the thing describing what can match).
->
Is is true that '4.1'(the thing being matched) is >= '4.0' (the thing
describing what can match).
(which is still correct).

But we're putting the thing which can match first, so we need to invert it all.

Anyhow - I think we need a second test still, and the change should be
from >= to <, without adding the word not. (or just add the word not)

-- 
https://code.launchpad.net/~allenap/testtools/lessthan-mismatch-string/+merge/57323
Your team testtools developers is requested to review the proposed merge of lp:~allenap/testtools/lessthan-mismatch-string into lp:testtools.



References