testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

Review: Approve
OK. This time for sure.

assertThat(too_big, LessThan(small)) fails.

You can express this as:
 A. not (too_big < small); too_big not < small
 B. too_big >= small
 C. small <= too_big
 D. not (small > too_big); small not > too_big

I defy anyone to disagree.

Gavin's patch does 'D', which is correct.

Trunk does 'small >= too_big', which is probably a well-intentioned but wrong version of B.

The proper fix for this bug would put 'too_big' in front (actually I think putting 'observed' in front might make sense in general -- another conversation). However, Gavin's fix is both correct and an incremental improvement.

-- 
https://code.launchpad.net/~allenap/testtools/lessthan-mismatch-string/+merge/57323
Your team testtools developers is subscribed to branch lp:testtools.