testtools-dev team mailing list archive

["Martin \[gz\]" <gzlist@xxxxxxxxxxxxxx>]

Specifically, TestTestProtocolClient methods test_add_unexpected_success
and test_add_unexpected_success_details should fail if the output
streams begin with "successful" as they do currently rather than
"failure" or similar.

** Changed in: subunit
       Status: Incomplete => Confirmed

-- 
You received this bug notification because you are a member of testtools
developers, which is subscribed to testtools.
https://bugs.launchpad.net/bugs/654474

Title:
  An unexpectedSuccess is like a failure not a success

Status in Bazaar Version Control System:
  Confirmed
Status in SubUnit:
  Confirmed
Status in testtools:
  Fix Released

Bug description:
  When the function passed to expectedFailure did not raise an
  assertion, bzr used to do:

      self.fail('Unexpected success.  Should have failed: %s' % reason)

  With testtools, bazaar now treats that as a success, as jam noted in February:
  <https://lists.ubuntu.com/archives/bazaar/2010q1/066898.html>

  And in September he pointed out the same thing, but with subunit:
  <https://lists.ubuntu.com/archives/bazaar/2010q3/070192.html>