testtools-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~gz/testtools/unicode_doctestmatches_764170 into lp:testtools

To: "Martin \[gz\]" <gzlist@xxxxxxxxxxxxxx>
From: Jonathan Lange <jml@xxxxxxxxx>
Date: Mon, 04 Jul 2011 18:23:23 -0000
In-reply-to: <20110702004631.2267.72345.launchpad@loganberry.canonical.com>
Reply-to: mp+66674@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Thanks for the patch and for the thorough analysis. I'll merge it now.

More broadly, I don't know what we should do here. Is it possible to get DocTestMatches breaking in a consistent, helpful, documented way with a nice error message? (e.g. Say "only works for ASCII".) That might be preferable to jumping through hoops to work around broken stdlib.


-- 
https://code.launchpad.net/~gz/testtools/unicode_doctestmatches_764170/+merge/66674
Your team testtools developers is subscribed to branch lp:testtools.

References

[Merge] lp:~gz/testtools/unicode_doctestmatches_764170 into lp:testtools
From: Martin [gz], 2011-07-02