← Back to team overview

testtools-dev team mailing list archive

Re: [Merge] lp:~gz/testtools/unicode_doctestmatches_764170 into lp:testtools

 

Review: Needs Fixing
I've had to revert this because it breaks the test suite, both with Python 2.7 and 3.


$ make check
PYTHONPATH=/home/jml/src/testtools/trunk python -m testtools.run testtools.tests.test_suite
Tests running...
======================================================================
FAIL: testtools.tests.test_matchers.TestDocTestMatchesInterfaceUnicode.test_describe_difference
----------------------------------------------------------------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "testtools/runtest.py", line 169, in _run_user
    return fn(*args, **kwargs)
  File "testtools/testcase.py", line 566, in _run_test_method
    return self._get_test_method()()
  File "testtools/tests/test_matchers.py", line 89, in test_describe_difference
    self.assertEqual(difference, mismatch.describe())
  File "testtools/testcase.py", line 310, in assertEqual
    self.assertThat(observed, matcher)
  File "testtools/testcase.py", line 412, in assertThat
    % (matchee, matcher, mismatch.describe()))
AssertionError: Match failed. Matchee: "Expected:
    ��
Got:
    a
"
Matcher: Equals('Expected:\n    \\xa7\nGot:\n    a')
Difference: !=:
reference = 'Expected:\n    \\xa7\nGot:\n    a'
actual = 'Expected:\n    \xc2\xa7\nGot:\n    a\n'


------------
Ran 679 tests in 1.183s

FAILED (failures=1)

-- 
https://code.launchpad.net/~gz/testtools/unicode_doctestmatches_764170/+merge/66674
Your team testtools developers is subscribed to branch lp:testtools.


References