testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

Hello,

Christian Kampka has had a patch on testtools for a long time now:
  <https://code.launchpad.net/~kampka/testtools/test-to-fixture/+merge/65034>

I don't really know what to do about it. It feels somehow wrong to me,
partly because it's a poor way of implementing shared fixtures (we
should really do that btw), partly because it seems to me that it
ought to be part of the general fixtures protocol (any fixture that
uses a fixture should then insert itself on the used fixture) and
partly because I dislike setting attributes like that.

I think I've said most of those things on the review. I'd appreciate
input from others.

jml