← Back to team overview

testtools-dev team mailing list archive

[Merge] lp:~jml/testtools/distribute-compatible-snapshot into lp:testtools

 

Jonathan Lange has proposed merging lp:~jml/testtools/distribute-compatible-snapshot into lp:testtools.

Requested reviews:
  testtools committers (testtools-committers)

For more details, see:
https://code.launchpad.net/~jml/testtools/distribute-compatible-snapshot/+merge/83429

I've been doing a lot of stuff with virtualenv recently (blech), and have been hit by an issue where sometimes a package needs testtools >= 0.9.11, but the version installed on my system is "snapshot" because it's the daily build (which, for whatever reason, can't get the revno).

This patch adds the version number to the string "snapshot" so it can be used properly.


-- 
https://code.launchpad.net/~jml/testtools/distribute-compatible-snapshot/+merge/83429
Your team testtools developers is subscribed to branch lp:testtools.
=== modified file 'setup.py'
--- setup.py	2011-02-28 12:12:03 +0000
+++ setup.py	2011-11-25 18:26:23 +0000
@@ -45,7 +45,10 @@
         return pkg_info_version
     revno = get_revno()
     if revno is None:
-        return "snapshot"
+        # Apparently if we just say "snapshot" then distribute won't accept it
+        # as satisfying versioned dependencies. This is a problem for the
+        # daily build version.
+        return "snapshot-%s" % (version,)
     if phase == 'alpha':
         # No idea what the next version will be
         return 'next-r%s' % revno


Follow ups