← Back to team overview

testtools-dev team mailing list archive

[Merge] lp:~jml/testtools/wrap-result-in-concurrent-suite into lp:testtools

 

The proposal to merge lp:~jml/testtools/wrap-result-in-concurrent-suite into lp:testtools has been updated.

Description changed to:

>From talking with Benji, it looks like they need to be able to wrap up the per-thread results in ConcurrentTestSuite so that they can tag the tests in those results.  This branch adds a hook.

I'm not 100% convinced by this change.  I think that perhaps the only valid use is (once https://code.launchpad.net/~jml/testtools/tagger/+merge/101904 is merged) to do this::

    def _wrap_result(self, per_thread_result, thread_number):
        return Tagger(per_thread_result, set(['thread-%s' % (thread_number,)]), set())

And so we might as well do that.  On the other hand, the approach in this branch feels a little more "small pieces, loosely joined".

For more details, see:
https://code.launchpad.net/~jml/testtools/wrap-result-in-concurrent-suite/+merge/101902
-- 
https://code.launchpad.net/~jml/testtools/wrap-result-in-concurrent-suite/+merge/101902
Your team testtools developers is subscribed to branch lp:testtools.


References