testtools-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/testtools/bug-1019165 into lp:testtools.

Requested reviews:
  testtools committers (testtools-committers)
Related bugs:
  Bug #1019165 in testtools: "AttributeError: 'ThreadsafeForwardingResult' object has no attribute 'progress' - does not support the progress protocol."
  https://bugs.launchpad.net/testtools/+bug/1019165

For more details, see:
https://code.launchpad.net/~lifeless/testtools/bug-1019165/+merge/140376

Permit testr run with streams containing progress markers to work.
-- 
https://code.launchpad.net/~lifeless/testtools/bug-1019165/+merge/140376
Your team testtools developers is subscribed to branch lp:testtools.

=== modified file 'NEWS'
--- NEWS	2012-12-17 01:05:23 +0000
+++ NEWS	2012-12-18 09:46:08 +0000
@@ -6,6 +6,13 @@
 NEXT
 ~~~~
 
+Changes
+-------
+
+* ``ThreadsafeForwardingResult`` now defines a stub ``progress`` method, which
+  fixes ``testr run`` of streams containing progress markers (by discarding the 
+  progress data). (Robert Collins, #1019165)
+
 0.9.23
 ~~~~~~
 

=== modified file 'testtools/testresult/real.py'
--- testtools/testresult/real.py	2012-12-15 13:02:26 +0000
+++ testtools/testresult/real.py	2012-12-18 09:46:08 +0000
@@ -471,6 +471,9 @@
         self._add_result_with_semaphore(self.result.addUnexpectedSuccess,
             test, details=details)
 
+    def progress(self, offset, whence):
+        pass
+
     def startTestRun(self):
         super(ThreadsafeForwardingResult, self).startTestRun()
         self.semaphore.acquire()