testtools-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxx>]

I've cast a quick eye over the last 24 hours of commits and nothing stands
out as needing an immediate fix, so LGTM.

Do we need some more tests for setUpClass 'support'?

On Sat Nov 15 2014 at 10:03:23 PM Robert Collins <robertc@xxxxxxxxxxxxxxxxx>
wrote:

> So, I've had to push a few revs up without full review today - that
> makes me sad, and obviously I'll do any remedial work folk need, but I
> think its all solid stuff.
>
> tl;dr - when I released 1.2.0 it uncovered two issues:
>  - we didn't have a min version dependency on unittest2, and we needed
> one. Travis typically won't show that up (a mode to pip that installs
> the minimum acceptable version from the dependencies listed would
> help).
>  - our setUpClass support is fragile (and still is) and had broken
> hard, I think thats fixed.
>
> So we're now up to 1.3.0, with unittest2 a given dependency, which
> should make a bunch of stuff easier to reason about.
>
> Of course, in 60m we may find more issues, but I hope not :)
>
> -Rob
>
> --
> Robert Collins <rbtcollins@xxxxxx>
> Distinguished Technologist
> HP Converged Cloud
>
> _______________________________________________
> Mailing list: https://launchpad.net/~testtools-dev
> Post to     : testtools-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~testtools-dev
> More help   : https://help.launchpad.net/ListHelp
>