← Back to team overview

torios-dev team mailing list archive

Re: progress indicator

 

Hi Nio
(inlines)
On 10/13/2015 10:32 AM, Nio Wiklund wrote:
> Hi Israel,
>
> I would be happy with dialog in the OBI for ToriOS 1.0. It is tested a
> lot, and modified slowly from my original version, so I think we can
> rely on it. Still, it needs testing, to be sure that the recent changes
> have not borked anything.
Indeed!  I changed very little, so it should do the same thing.  I have
since modified things to log things more quietly, but very little has
changed in OBI.
I mostly added:
if [ "$USEZENITY" == "true" ]
then
#new code
else
#old code
fi
as well as a few
[[ "$USEZENITY" == "true" ]] && #modify text for html or something like that
[[ "$USEZENITY" != "true" ]] && #do something that will mess up the text
for html or something terminal/dialog specific

> And we need to debug and test how grub is installed. As I wrote 'some
> mail ago', it would be a good idea to let the user select where to
> install it (to which drive). This would be a new feature, that I think
> is important because the default target is changed to /dev/sda.
Could you send a zenity and dialog script for this?  Or point me to what
function I can reuse code from in mkusb or OBI.

I can easily put this in the grub-installer script, but I have since
fixed the problem with mkpxpy.  grub-installer defaults to /dev/sda if
NOTHING is sent in to it.  But, regardless it would be nice to offer a
specific place to install grub, but it will require more testing... for
example if grub is to be installed somewhere where grub-install does not
exist we will have to use the liveCD grub-install which has caused
issues in a previous ISO and will take a lot of testing.
> When confident with zenity in the OBI, I would be ready for ToriOS 1.1.
> Of course there will be some minor bug-fixes too, plus up-to-date
> versions of all the program packages.
sounds good to me
> ..
>
> Den 2015-10-13 kl. 16:02, skrev Israel:
>> ....
>>
>> On 10/13/2015 01:47 AM, Nio Wiklund wrote:
>>> Hi Israel.
>>>
>>> ....
>>>
>>> I added the option -n to pv and used its output in zenity.
>> Ok. that sounds like a good idea

[[ "$USEZENITY" == "true" ]] && (tar -xvJf "$trbll" | pv -n -s $(du -sb
. | awk '{print$1}')) 2>&1 | zenity --progress
--title="$OneButtonInstaller"  "$ZEN_ICON" --text="$Extracting $trbll"
--auto-close
is what I use now

>>> ....
>> So you think I should make an overall progress indicator?
> I think it would improve the user experience - not as important as a
> progress indicator for extracting from the tarball - but worthwhile.
Yeah, I suppose I could just use the log file to do this, and add a
progress number occasionally and have an 'overall progress' indicator window
This will create more issues, and should wait until later I think, as it
will make for a lot more debugging and testing to make sure things work
correctly
>>> ...
>>> .
> Installing the bootloader is a rather quick process, and can be one step
> in a crude stepwise indication (like in mkusb).
>
> Make a persistent live drive with mkusb and watch the progress
> indication! (I suggest that you test the bleeding edge version, now 10.3)
So would this be better than the current --pulsate ?
To me this is sufficient since it does go so quickly as you have said.
>> These are all very good ideas Nio!  Thank you!
>>> Best regards
>>> Nio


-- 
Regards



Follow ups

References