← Back to team overview

touch-packages team mailing list archive

[Bug 1336548] Re: SurfaceConfigurator::attribute_set always say "unfocused" for focus property changes

 

** Branch linked: lp:ubuntu/utopic-proposed/mir

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to mir in Ubuntu.
https://bugs.launchpad.net/bugs/1336548

Title:
  SurfaceConfigurator::attribute_set always say "unfocused" for focus
  property changes

Status in Mir:
  Fix Committed
Status in “mir” package in Ubuntu:
  Triaged

Bug description:
  1- call surface->configure(mir_surface_attrib_focus, mir_surface_focused);
  2- BasicSurface calls SurfaceConfigurator::select_attribute_value(surface, mir_surface_attrib_focus, mir_surface_focused).
  3- SurfaceConfigurator::select_attribute_value implementation returns mir_surface_focused

  Expected outcome:

  BasicSurface calls SurfaceConfigurator::attribute_set(surface,
  mir_surface_attrib_focus, mir_surface_focused)

  Actual outcome:

  BasicSurface calls SurfaceConfigurator::attribute_set(surface,
  mir_surface_attrib_focus, mir_surface_unfocused)

  We likely need this:

  --- src/server/scene/basic_surface.cpp  2014-06-24 14:12:25 +0000
  +++ src/server/scene/basic_surface.cpp  2014-07-01 17:09:59 +0000
  @@ -469,6 +469,7 @@ int ms::BasicSurface::configure(MirSurfa
           break;
       case mir_surface_attrib_focus:
           observers.attrib_changed(attrib, value);
  +        result = value;
           break;
       case mir_surface_attrib_swapinterval:
           allow_dropping = (value == 0);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mir/+bug/1336548/+subscriptions